This replaces the delegate email with their id in the select delegate dropdown (exposing email is a privacy issue).
It also makes the hardcoded default select text (choose delegate) a translateable field.
Finally, in order to remove delegate emails from the views entirely, I switched api_state to carry the delegate's id rather than email. While api_state never is rendered in the views, there was a form hidden field that was still email, and removing that encouraged me to remove emails altogether.
So while email is still used both as an argument to the Liquidvoting module as well as to our api, the view rendering logic, and view contents are free of email.
I think delegator and delegate should be passed to Liquidvoting as Decidim::Users rather than their emails, that would separate the concept from how we techically communicate them to the api, but that's for another day :-)
This replaces the delegate email with their id in the select delegate dropdown (exposing email is a privacy issue).
It also makes the hardcoded default select text
(choose delegate)a translateable field.Finally, in order to remove delegate emails from the views entirely, I switched
api_stateto carry the delegate's id rather than email. Whileapi_statenever is rendered in the views, there was a form hidden field that was still email, and removing that encouraged me to remove emails altogether.So while email is still used both as an argument to the
Liquidvotingmodule as well as to our api, the view rendering logic, and view contents are free of email.I think delegator and delegate should be passed to
LiquidvotingasDecidim::Users rather than their emails, that would separate the concept from how we techically communicate them to the api, but that's for another day :-)Closes #100