Fix broken assembly proposal specs

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0

4 stars 0 forks source link

Fix broken assembly proposal specs #119

Closed davefrey closed 3 years ago

davefrey commented 3 years ago

In PR #118 we introduced four new specs meant to test that supporting and delegating also works for Assembly proposals, but we inadvertently built fixtures for Process proposals.

(see first commit that should have turned specs red, and second commit which explains why it didn't)

[x] get the single red spec green by building an Assembly component
[x] ~insure all four Assembly specs are red when we move them to Assembly components (because their routes are commented)~ Only the two delegation specs should break on absence of routes; confirmed this is true
[x] uncomment routes, should be green now

There is an example of an Assembly component here: 633f0056ce5d64ad7d7f5aa101a3a2d9f4d4b6eb

Closes #43

jinjagit commented 3 years ago

But they did break when I commented out the assembly route in engine.rb

oliverbarnes commented 3 years ago

Seems like this should be draft? As routes are commented out

davefrey commented 3 years ago

I'm going to undraft this.

The one potential remaining issue in my mind is that we had to change our assembly proposal specs to visit a URL rather than a PATH, to work around a RoutingError. I'd like the reviewers to weigh in if this is a concern. It might have something to do with engine isolation settings?

Edit: the setting I was thinking of is isolate_namespace Decidim::Liquidvoting but commenting it doesn't fix the RoutingError when visiting the path.