search

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Add rubocop #23

Closed jinjagit closed 3 years ago

jinjagit commented 3 years ago

First steps in addressing #20

Next step (perhaps for another PR): Integrate with CI - which will need some setup of secrets on this repo. (specifically: secrets.GITHUB_TOKEN)

jinjagit commented 3 years ago

Note: I have, so far, followed much of the content found in Ruby on Rails project RuboCop setup with RSpec (just to get going on this WIP and start finding my way around this set of tools). I am aware this covers more ground than just linting and also includes performance and testing tools.

jinjagit commented 3 years ago

I have 'fixed' about 60+ 'offenses' :construction_worker:

rubocop_says_no_offences

Please look over the changes to help ensure I have not made anything worse / broken with my 'fixes'. Thanks!
I have highlighted 2 particular 'fixes' I am most unsure about with specific comments.

jinjagit commented 3 years ago

@Oliver "Did it say why it's useless?"

Yes, but I forgot to copy the message.
But I remember it said something like: 'Useless private access modifier. Maybe you meant: private_class_method '

I used https://github.com/rubocop-hq/rubocop/issues/6076 as a reference, and decided my best guess was it just doesn't need to be private. But I also flagged it up, as I really don't know enough to decide.