Add Rubocop to CI - Githubissues

jinjagit commented 3 years ago

Closes #20

jinjagit commented 3 years ago

Rubocop now running in CI:

rubocop_CI

Tested with syntax error and CI failed with correct rubocop 'offense'.
After some experimentation, I opted for the Rails way as recommended for forked repos. in Rubocop Linter Action
I didn't name the action 'Linting', as Rubocop is doing a bit more than just linting here, and I am guessing most contributors would have at least an idea of what Rubocop is/does.
We could use single build.yml file, as both on_push.yml and on_pull_request.yml are functionally equivalent at present.

jinjagit commented 3 years ago

Now with added badge goodness:

badges

liquidvotingio / decidim-module-liquidvoting