search

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Edit gem name to be 'decidim-liquidvoting'. #28

Closed jinjagit closed 3 years ago

jinjagit commented 3 years ago

These are the changes that got the demo working again for me, locally.

Tested in 'emulate-original-vote-button feature' branch by running liquid-decidim-demo + our API, and seeing our new UI additions working.

I am unsure if we should also rename decidim-module-liquidvoting.gemspec to be decidim-liquidvoting.gemspec, so I did not make this change.

oliverbarnes commented 3 years ago

Reviewing a conversation with Andrés the convention seems to be decidim-module-* for the gem name as well, not just the repo name. Mirroring the naming makes things predictable too.

oliverbarnes commented 3 years ago

But it'd be good to go through some more examples of third-party decidim modules to confirm this

jinjagit commented 3 years ago

Reviewing a conversation with Andrés the convention seems to be decidim-module-* for the gem name as well, not just the repo name. Mirroring the naming makes things predictable too.

I have no preference, but if we change the gem name, we need to mirror that in all places it is used, including liquid-decidim-demo, to keep the whole setup working.

oliverbarnes commented 3 years ago

That's fine. The only issue is whether we'd need to use "Decidim::Module" namespacing within the gem, which I'd rather avoid - unless that's really the convention. Hence the need to look at other examples to confirm

jinjagit commented 3 years ago

The coopdevs action-delegator module gemspec file and Gemfile, as one example.

The mainio decidim-module-plans also seems to follow same conventions as coopdevs, in their gemspec file and Gemfile. Not sure how canonical mainio are, though.

And here's an OSP module: decidm-module-budgets_enhanced.