search

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Remove liquidvoting component #40

Closed davefrey closed 3 years ago

davefrey commented 3 years ago

You will also need to remove the 'liquidvoting' row from the database, or you will get something like:

ActionView::Template::Error (undefined method `decidim_participatory_process_liquidvoting' for #

The last segment 'liquidvoting' of that method name is dynamically retrieved from the database, from decidim_components.manifest_name; changing the value changes the method name lookup. Removing the row lets things work again.

This seems to leave the code broken in exactly the same ways as before: view rendering fails on current_settings etc

davefrey commented 3 years ago

Definitely I don't like the TODOs and I expect most to go away quickly, and I agree issues are better than TODOs.

For the moment they're my placeholders as I better understand things; it feels premature to issue-ize them. Give me a few more commits on this PR :-)

Also it seems I've got some PRs maybe out of order; this PR will be cleaner after #42 and then #39 are merged.

oliverbarnes commented 3 years ago

Hehe, sure! But it sounds like the PR is draft, then?

davefrey commented 3 years ago

I cleaned things up a bit, the TODOs in particular really belong to other demo work threads. I'll un-draft this.