search

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Reduce memoized #41

Closed davefrey closed 3 years ago

davefrey commented 3 years ago

This issue is to understand why we use so many memoized helpers, and (re)write better specs.

With a recent update of rubocop we had a lot of new offences for RSpec/MultipleMemoizedHelpers. Rather than fix the specs now, I bumped the Max from 5 to 12, but this is probably a smell for bad specs.

davefrey commented 3 years ago

So the rubocop changes that caused this Issue (introducing a Max parameter) seem to have been based on a wrong version of rubocop or ruby, and have been reverted.

Since rubocop is clean on the current master, I'll close this issue.