Integrate Assembly Proposals

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0

4 stars 0 forks source link

Integrate Assembly Proposals #43

Closed oliverbarnes closed 3 years ago

oliverbarnes commented 3 years ago

This is analogous work to integrating Liquidvoting for Proposal Supports, but for Assembly Proposals.

[x] ~add decidim-assemblies gem~ - Rather, we removed all except decidim gem
[x] check for migrations or other assembly-specific dependencies
[x] add routes to engine
[x] add specs with proper assembly proposal fixtures

davefrey commented 3 years ago

We found just generalizing the route to have a variable placeholder instead of a hardcoded participatory process route, implements the change.

However, specs are harder, and we stopped after spending some time trying to get fixtures to support a spec proving the route does what we want (delegations on assembly proposals).

davefrey commented 3 years ago

The route to add seems to be /assemblies/:assembly_slug/f/:component_id

davefrey commented 3 years ago

We double the route declarations across the two participatory spaces (process and assembly), they're nearly identical, but this feels more comfortable than trying to understand if there's a magic parameter symbol for the space.

oliverbarnes commented 3 years ago

Agreed, it's better to be explicit here