search

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Step up to supporting proposal lists, or not #50

Open davefrey opened 3 years ago

davefrey commented 3 years ago

Proposal controllers set a variable from_proposals_list, it's carried as a param and used in views to conditionally render.

I think one thing it may be used for is allowing voting from the proposals view (rather than only on the specific proposal view).

I think our general approach until now has been to hardcode the variable to true, but it's not clear to me if we do it consistently, or if that's what we want.

This issue is to grok the variable's usage, choose to step up to using it dynamically or leave it static, and insure it's done consistently across our module.

davefrey commented 3 years ago

Note there is also a @proposals instance variable, and an associated query. The cleanup requested in this issue should take that into account as well.