search

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Update CI to test and teardown #62

Closed oliverbarnes closed 3 years ago

oliverbarnes commented 3 years ago

Include specs, and merge on_pull_request and on_push flows, as they were exactly the same

oliverbarnes commented 3 years ago

Merged #61 into here to get past the data migration problem - had a hunch a newer decidim version would fix them, and it did.

This is now using ruby 2.7.2 and decidim 0.24.0.rc2. Gemfile and views were updated accordingly.

Couldn't test with the demo yet, due to error in seeds (https://github.com/liquidvotingio/liquid-decidim-demo/pull/13). That's blocking merging this, so I'm setting the PR to draft

davefrey commented 3 years ago

Closes #63

davefrey commented 3 years ago

Oliver I think you did a diff between all of our module files and v0.24.rc2, because I see view updates on our side, but could you confirm?

davefrey commented 3 years ago

Whew! I think all the intentions for this PR have been met. We should extend spec coverage and do some other debt cleanup (already issued), but imo this is ready for a final review and merge

davefrey commented 3 years ago

Mmm I can't add oliver as a second reviewer, but I did the last coding here.

@oliverbarnes would you mind giving this a last review and merge or ping me if it's okay.

oliverbarnes commented 3 years ago

Oliver I think you did a diff between all of our module files and v0.24.rc2, because I see view updates on our side, but could you confirm?

👍 yes I did