liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Proposals main page needs to reflect supported/delegated #89

Closed davefrey closed 3 years ago

davefrey commented 3 years ago

The main Proposals page doesn't reflect the vote/delegate status (the 1 Support = the current user):

image

To replicate, go to a specific Proposal page, Support it, then go back to the main Proposals page (trim the proposal id from the url for example). The Support button remains enabled, and clicking it has no visible effect in the UI (the api call fails and a 500 is written to the rails log)

Here are some possible remedies:

davefrey commented 3 years ago

"Rejected" proposals remove the Support button; here's an example of how things would look when only showing the Supports (and Endorsements, thinking ahead) and now allowing voting on the main page: image

So option 3 from above is the easiest for us, and is not so bad from a UX perspective

oliverbarnes commented 3 years ago

Technically not a bug, as it was never implemented :) But good catch, we didn't have it in our backlog yet.

Hiding the button for now is a good provisory solution, until we integrate things here too. We'll have to give it some careful design to keep this already busy card from becoming a mess...

davefrey commented 3 years ago

This is replaced by #104, I'm closing the current issue