search

liquidvotingio / decidim-module-liquidvoting

GNU Affero General Public License v3.0
4 stars 0 forks source link

Rename api call to :fetch_user_voted? #93

Closed davefrey closed 3 years ago

davefrey commented 3 years ago

Our Decidim module has three layers or spaces when dealing with our Liquidvoting api:

  1. the ApiClient - client code that calls our Liquidvoting api. It should be generic, without any Decidim-ness
  2. the Decidim::Liquidvoting module - a kind of facade that wraps Liquidvoting activities like calling the api or bundling current api state. This is where we can map Liquidvoting-generic things like api calls to Decidim-specific terms
  3. this Decidim module - it uses the Decidim::Liquidvoting module to get Liquidvoting things done

This PR is to remove the Decidim-specific term "support" from our ApiClient, yet preserve it in our Liquidvoting module facade/mapper.

Resolves #92

davefrey commented 3 years ago

@jinjagit reviewing this PR and description might answer your question from the planning meeting today, about how we use the Liquidvoting module as a place to isolate Decidim things from neutral api things...lmk if it's still unclear :-)