search

liquidweb / LiquidWeb-WHMCS-Plugin

17 stars 13 forks source link

Code Upgrades? #8

Open idevwebs opened 7 years ago

idevwebs commented 7 years ago

Hi there. Pretty soon, support for mysql_* functions will be officially dropped. Are there any plans to upgrade the code in this plugin anytime soon?

mallardduck commented 7 years ago

Thank you for reporting this concern, I will raise this issue internally and will see how this could be addressed.

mallardduck commented 7 years ago

@mike7892 from what I can see this issue is still active and in the code.

As WHMCS has provided a builtin database connection library since 6.0 and on, I believe we need to begin targeting a project to rewrite code based on that functionality. I think this should be tagged as a project for a Minor release point, although depending on the rewrite size I could see it requiring a major version bump.

The builtin DBAL is called Capsule and also provides Laravels ORM called Eloquent. Between both we should easily be able to replace any directly used mysql_* functions in favor of one of these abstractions. This will provide a more cohesive WHMCS compatibility with out plugin and should help ensure our plugins compatibility.

As I'm quite familiar with Laravel if needed I'd be happy to help with this task - time permitting.

jmzolezzi commented 5 years ago

Are there any plans to rewrite the module to use builtin WHMcs calls?