search

liquidweb / wme

3 stars 1 forks source link

Bugfix: Fix Github Workflows Playwright end to end tests #201

Closed defunctl closed 1 year ago

defunctl commented 1 year ago

The problem

Playwright is manually installed as a step during the workflow, but pnpm-lock.yaml has a deep dependency of of playwright-core locked at version 1.29.1. However, Playwright's current version is at 1.30.0 so when npx playwright install chromium --with-deps is run, it installs a newer version and that mismatch causes the job to fail.

The Solution

I ended up writing a little bash one-liner to extract the currently locked version of @playwright/test, which is locked to the same playwright-core version.

pnpm list -r --parseable | grep -m 1 playwright+test | cut -d "@" -f3

This outputs 1.29.1 and we simply pass that to the install command.

image

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: e5d78a5b978c9add93bfbe4af0f4474cd4e04bda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

defunctl commented 1 year ago

@bswatson I'm going to merge this one since it fixes the issue, at least for now. Just reach out if we need to adjust it and we'll sort it out.