search

liquidweb / wme

3 stars 1 forks source link

Thoughts on replacing the container with di52? #205

Open defunctl opened 1 year ago

defunctl commented 1 year ago

Given it supports the same PHP versions, but supports auto-wiring, this would drastically reduce the number of definitions we need, supports Service Providers out of the box, and is a lot more "Laravely" in syntax.

Additionally, it is used with many other internal products here.

https://github.com/lucatume/di52

bswatson commented 1 year ago

I'm good with swapping it out on the v2+ (main) branch, we'll need to also include a transition guide so implementors know how to swap out usages for StoreBuilder.

https://github.com/liquidweb/nexcess-mapps/blob/develop/nexcess-mapps/Integrations/StoreBuilder.php#L128-L131 https://github.com/liquidweb/nexcess-mapps/blob/develop/nexcess-mapps/Integrations/StoreBuilder.php#L149 https://github.com/liquidweb/nexcess-mapps/blob/develop/nexcess-mapps/Integrations/StoreBuilder.php#L407