liquidweb / wme

3 stars 1 forks source link

[SITE-303] Site Details Page & Cards #234

Closed bswatson closed 1 year ago

bswatson commented 1 year ago

This PR covers multiple tickets:

It is based on #223 and should either be merged into that branch or if that branch is merged first, then the PR should be updated and merged directly to main once completed.

The changes in this PR are available to test on https://0020f93ddd.nxcli.io/

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: bb99ff5a9fa74cff12bf4cb62ffd5ceee6417e83

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

bswatson commented 1 year ago

@aykanburcak wanted to call your attention to plugins/wme-sitebuilder/wme-sitebuilder/Cards/Shipping.php which duplicates and conflicts with your work on #236.

aykanburcak commented 1 year ago

@aykanburcak wanted to call your attention to plugins/wme-sitebuilder/wme-sitebuilder/Cards/Shipping.php which duplicates and conflicts with your work on #236.

Looks like the only addition on my PR is the footer links of shipping card. I can rebase my branch after you merge this. Does it sound ok to you @bswatson ?

bswatson commented 1 year ago

Sounds great! I'll get this merged and then we can wrap that up.