search

liquidweb / wme

3 stars 1 forks source link

[SITE-291] Site visibility card backend service implementation #247

Closed aykanburcak closed 1 year ago

aykanburcak commented 1 year ago

Screenshot

Screen Capture on 2023-05-01 at 19-31-41

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 6c47dedfb8ef407a04ee256a8ada9b5c1c12a5b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

aykanburcak commented 1 year ago

Since there's some wait time, should there be a loader shown in the status chip when you select/deselect the setting?

I added a loader component into wme-ui and included it to Site Visibility card. Can you take a second look for code review @lukefrogger ?