search

liquidweb / woocommerce-custom-orders-table

Store WooCommerce order data in a custom table for improved performance.
GNU General Public License v3.0
476 stars 51 forks source link

wp_postmeta not reduced in size after migration? #150

Closed mooseweb closed 2 years ago

mooseweb commented 4 years ago

Describe the bug wp_postmeta did not decrease in size at all nor did it seem to lose any of its original stored data.

Expected behavior

The initial migration timed out (SSH timed out) at 97% on roughly 49,000 orders being migrated. I started it back up for the last 3% and it completed successfully. But the original wp_postmeta table is still massive (same size as when we started).

Versions WordPress & Woocommerce are latest versions and nearly all plugins were disabled before the start of the migration.

Additional context I also just double checked and noticed that none of the markers to save the original postmeta were in the cli command.

stevegrunwell commented 4 years ago

Hey @mooseweb, thank you for the report!

Can you please verify which version of the Custom Orders Table plugin you're running?

mooseweb commented 4 years ago

The most recent, I followed instructions from the readme portion of the front-page to the letter. It did convert all the orders over, but the database went from ~700mb to ~970mb. The original postmeta merely stayed the same and when I manually explored it, it still had the orders data scattered throughout.

juliquiron commented 4 years ago

@mooseweb maybe this PR and it's discussion is relevant to you: https://github.com/liquidweb/woocommerce-custom-orders-table/pull/136 :+1:

ryonwhyte commented 4 years ago

@stevegrunwell I noticed that there are still a lot of order meta entries still in the post meta table. All custom fields as well as wc-plugin fields like stripe. I followed the instructions correctly and did the migration and the new table was populated. Is it normal behavior for order meta to remain in the post meta table?

If so doesn't this defeat the purpose of flattening the table to improve speed?

juliquiron commented 4 years ago

Hi @ryonwhyte I have the same issue, and in the PR of my previous comment, you can find a quite extensive discussion about it.

TL;DR: this plugin only migrates the order fields which are in WC core and keeps in post_meta all other fields, as you say. IMHO this is not a solution but they focus on do this first step into core and then see if possible to move forward.

https://github.com/liquidweb/woocommerce-custom-orders-table/pull/136 this PR is a proof of concept (aka, in our case it works) of creating another table to store the remaining values in post_meta into a new table.

ryonwhyte commented 4 years ago

Thank you @juliquiron your proposed solution would make sense. Well, until then I am afraid the plugin may not have a great impact for me. I am using mostly custom order fields, so almost all the order data in still in post_meta.