liquidx / plotkit

Automatically exported from code.google.com/p/plotkit
0 stars 0 forks source link

line graphs: going through 0,0 and maxX,0 seems errant; !shouldFill looks strange #4

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Setting shouldFill = false tells PK not to fill in the line graphs;
however, the graph still has closed wire frame that:

1) starts at 0,0 (even if it’s not in the data set)
2) goes through each point of the data set (this is correct)
3) goes to the maxX,0 point (lower-right corner)
4) goes back to 0,0
5) is always white, regardless of the colorScheme setting

The expected behavior for non-filled line graphs would seem simply to be
going through each point with a line of the data set’s color.

Moreover, the filled line graphs should not go through 0,0 and maxX,0; they
should simply go down to the X axis from the first and last points of the
data set.

I am attaching a patch to SweetCanvas.js that resolves both of these issues
for that renderer.

Original issue reported on code.google.com by fel...@felipegasper.com on 16 Mar 2010 at 6:38

GoogleCodeExporter commented 9 years ago

Original comment by fel...@felipegasper.com on 16 Mar 2010 at 6:44

Attachments: