liquidx / webviewscreensaver

Mac OS X Screen Saver powered by a Web View
Apache License 2.0
1.17k stars 138 forks source link

Use the WKWebView class instead of using WebView #41

Closed EstherSalinas closed 3 years ago

EstherSalinas commented 7 years ago

Hi,

Congratulations for your project. I'm using OS X 10.11 and this screen saver works for the README examples. But I have a web that uses arrow functions (I'm not sure if it is the reason) the screensaver is shown in black colour. I've read this in apple page:

In apps that run in OS X 10.10 and later, use the WKWebView class instead of using WebView.

https://developer.apple.com/documentation/webkit/wkwebview

Thank you in advance,

Esther.

pavellishin commented 6 years ago

(I'm not sure if it is the reason)

An accessible Javascript console of some sort would be helpful, too :/

jtoy commented 6 years ago

+1 . It runs too slow on WebView, the speed of executing pages is supposedly much faster on WKWebView

pavellishin commented 6 years ago

It runs too slow on WebView

I've noticed it's not super speedy, myself.

I've never opened up XCode in my life, except to update it. Is this something that's difficult to change, or is it literally just changing an import? @liquidx mentioned that he's doing maintenance, but not active development; I could try it, but I don't really want to sink three days into something that would take an experienced dev two hours.

jtoy commented 6 years ago

I have not done XCode either, but I was able to load the project in XCode and compile it. I think updating it to use WKWebView should be fairly easy: https://stackoverflow.com/questions/32290198/osx-webview-very-slow-and-laggy

round commented 6 years ago

This may be a helpful workaround: https://github.com/liquidx/webviewscreensaver/issues/16#issuecomment-351837159.

agologan commented 3 years ago

We switched to WKWebView in the latest version v2.1.