liquidz / antq

Point out your outdated dependencies.
Other
403 stars 25 forks source link

Detect :default-deps for Clojure CLI #155

Closed grzm closed 2 years ago

grzm commented 2 years ago

:default-deps is a resolve-deps modifier.

See https://clojure.org/reference/deps_and_cli#_resolve_deps_modifiers

It is sometimes used to indicate "managed-dependencies" or common pinned versions. See the following discussions

:default-deps isn't used by the cli tool directly, but is a known argument in the tooling itself.

We use this internally to indicate managed dependencies and having antq detect :default-deps would be useful.

liquidz commented 2 years ago

@grzm Thanks for your contribution!

Could you change the following line too? https://github.com/liquidz/antq/blob/c288140a9d94fd4ae22855b8e85f1e928cbd10ba/src/antq/upgrade/clojure.clj#L12

And it may be good that we have the set as constant value. https://github.com/liquidz/antq/blob/main/src/antq/constant.clj

grzm commented 2 years ago

Thanks for the suggestions! That makes a lot of sense in the context of the project as a whole.

grzm commented 2 years ago

Thanks for your review and merge, @liquidz !

liquidz commented 2 years ago

@grzm Just released v1.6.1 #156

grzm commented 2 years ago

🎉 🚀 🎸