liquidz / antq

Point out your outdated dependencies.
Other
395 stars 22 forks source link

Bug (Regression): incorrect deduction of git deps? #184

Closed seancorfield closed 1 year ago

seancorfield commented 1 year ago

The latest release introduces a breaking regression -- I think antq is incorrectly identifying a Maven group/artifact as a possible git URL?

Below is a minimal repro (the antq-bug folder contains nothing except the deps.edn file shown below):

(~/clojure/antq-bug)-(!1917)-> clojure -Sdeps '{:deps {com.github.liquidz/antq {:mvn/version "2.1.920"}}}' -M -m antq.core
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[##################################################] 1/1
Execution error (ExceptionInfo) at clojure.tools.gitlibs.impl/git-clone-bare (impl.clj:103).
Unable to clone /home/sean/.gitlibs/_repos/https/github.com/googleapis/java-vision/google-cloud-vision
remote: Not Found
fatal: repository 'https://github.com/googleapis/java-vision/google-cloud-vision/' not found

Full report at:
/tmp/clojure-3633139890989464225.edn

Mon Sep 19 11:04:51
(~/clojure/antq-bug)-(!1918)-> clojure -Sdeps '{:deps {com.github.liquidz/antq {:mvn/version "2.0.895"}}}' -M -m antq.core
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[##################################################] 1/1

|    :file |                                :name | :current | :latest |
|----------+--------------------------------------+----------+---------|
| deps.edn | com.google.cloud/google-cloud-vision |  1.103.7 |   3.1.1 |

Mon Sep 19 11:05:16
(~/clojure/antq-bug)-(!1919)-> cat deps.edn
{:deps {com.google.cloud/google-cloud-vision {:mvn/version "1.103.7"}}}

Mon Sep 19 11:05:20
(~/clojure/antq-bug)-(!1920)->
liquidz commented 1 year ago

@seancorfield Thanks for your reporting! Just released v2.1.927 to fix this bug.

seancorfield commented 1 year ago

That was fast -- thank you! Confirmed fixed locally.

seancorfield commented 1 year ago

Should I close this now that it is fixed, or is that part of your process?

liquidz commented 1 year ago

There is no special rules :)