liquidz / antq

Point out your outdated dependencies.
Other
403 stars 25 forks source link

Upgrade does not respect :antq/exclude flags #200

Closed wardle closed 1 year ago

wardle commented 1 year ago

I have a project that uses Apache Lucene. Some users are still on java 8 (!), and so cannot use Lucene 9.x series, so I have an alias that allows Lucene 8.x to be used instead. I have added ^:antq/exclude which means they are not shown when I use antq to show outdated dependencies. However, during upgrade, the interactive prompt asks whether I want to upgrade 9.4.2 to 9.5.0 and if I answer 'y', then dependencies other than 9.4.2 are also upgraded - ie 8.11.2.

I think that there are two reasons why these deps should not be upgraded. Presumably deps should not be upgraded a) if there is a :antq/exclude flag and b) if the interactive UI asks to upgrade from a specific version to another when a dep isn't at that specific version.

My source code is here https://github.com/wardle/hermes - this issue is currrently reproducible at HEAD.

Thank you for all of your hard work on antq - I think it is brilliant and makes it so easy to stay on top of my dependencies. This isn't a major issue at all - indeed, pretty trivial really, and easy to work around... Many thanks.

wardle commented 1 year ago

Duplicate of #199