search

liquidz / antq

Point out your outdated dependencies.
Other
394 stars 22 forks source link

Upgrade is not working when dependency version is destructed. #241

Closed Kaspazza closed 6 months ago

Kaspazza commented 7 months ago

Running upgrade on deps.edn will always tell which versions to update, but will not follow through if the version is saved as:

:mvn{:version "x.x"}

And will work correctly if the dependency is written in fully qualified keyword like: {:mvn/version "x.x"}

liquidz commented 7 months ago

@Kaspazza Thanks for your reporting! Ah, I missed it. I'll fix!

liquidz commented 7 months ago

@Kaspazza I've fixed in bugfix/upgrade-with-destructed branch. Could you try?

Kaspazza commented 7 months ago

@liquidz Hi, thank you for the quick reply and fix!

Yeah, it works, but it asks twice about the same dependencies (both with destructured or not)

I run it with code, requiring [antq.core] (antq.core/-main --upgrade --directory=/absolute/path/to/my/repo --exclude lib --exclude lib2 --exclude lib3)

First it asks about ~/absolute/path/to/my/repo/deps.edn and second time about relative deps.edn

Here is a screenshot:

image
liquidz commented 7 months ago

Hmm, I'll have a look.

liquidz commented 6 months ago

@Kaspazza Sorry, I've been unwell.

Yeah, it works, but it asks twice about the same dependencies (both with destructured or not)

Thanks for your reporting! This was another bug and I've fixed in the same branch. Could you try bugfix/upgrade-with-destructed branch again?

liquidz commented 6 months ago

@Kaspazza Just released v2.8.1165 :)

Kaspazza commented 6 months ago

@liquidz Great, thanks!