search

liquidz / antq

Point out your outdated dependencies.
Other
403 stars 25 forks source link

Does not detect outdated version of clj-kondo with DeLaGuardo/setup-clojure GitHub Action #248

Closed devurandom closed 7 months ago

devurandom commented 7 months ago

Given the following .github/workflows/lint.yml file:

name: Lint

on:
  pull_request

jobs:
  lint:
    runs-on: ubuntu-22.04
    steps:
      - name: Checkout
        uses: actions/checkout@v4
      - name: Prepare Java
        uses: actions/setup-java@v4
        with:
          distribution: 'temurin'
          java-version: '11'
      - name: Install Clojure tools
        uses: DeLaGuardo/setup-clojure@12.3
        with:
          cli: 1.11.1.1435
          clj-kondo: 2023.07.13

I see:

❯ clj -Tantq outdated :upgrade true
[##################################################] 4/4
All dependencies are up-to-date.

The current version of clj-kondo as of this report is 2023.12.15.

This is using:

❯ clj -Ttools list
TOOL      LIB                                 TYPE  VERSION
antq      com.github.liquidz/antq             :git  2.8.1173
...
liquidz commented 7 months ago

@devurandom Thank you for your reporting! I could reproduce the problem. I'll fix it :)

liquidz commented 7 months ago

@devurandom I've fixed dependencies detector and upgrader in dev branch to support :bb, :clj-kondo, :cljfmt, :cljstyle, and :zprint parameters on setup-clojure action. Could you try dev branch?

devurandom commented 7 months ago

I just tested badf6c9e6e0d55960698213d3aa6bc6a75f2cbeb and it suggests to update clj-kondo in GHA in addition to deps.edn:

| :file                                    | :name                                     | :current                                 | :latest                                  |
|------------------------------------------+-------------------------------------------+------------------------------------------+------------------------------------------|
| .github/workflows/lint.yml               | DeLaGuardo/setup-clojure                  | 12.3                                     | 12.5                                     |
|                                          | DeLaGuardo/setup-clojure                  | 12.3                                     | 12.5                                     |
|                                          | clj-kondo/clj-kondo                       | 2023.12.15                               | 2024.02.12                               |
| deps.edn                                 | clj-kondo/clj-kondo                       | 2023.12.15                               | 2024.02.12                               |

Thanks!

liquidz commented 7 months ago

@devurandom Thank you for your confirmation! Just released v2.8.1185 :)