search

liquidz / antq

Point out your outdated dependencies.
Other
403 stars 25 forks source link

antq.api/upgrade-deps! not working for dependencies that are keyword extracted #251

Closed Kaspazza closed 5 months ago

Kaspazza commented 6 months ago

Running this: (antq.api/upgrade-deps! [{:type :clojure, :file "automaton/automaton_core/bb.edn", :dependency {:name "org.clojars.hephaistox/automaton-build", :latest-version "1.3.0-5-la"}}])

Won't work if bb.edn (or deps.edn the same behavior on all) looks like this: {:deps #:org.clojars.hephaistox{automaton-build #:mvn{:version "1.0.2"}}} Which is perfectly valid format.

But will work if it looks like this: {:deps {org.clojars.hephaistox/automaton-build #:mvn{:version "1.0.2"}}

So having the namespace extended outside of curly brackets make it don't succeed (even though function itself returns true).

liquidz commented 6 months ago

@Kaspazza Sorry for late reply and thank you for your reporting! I'll have a look.

liquidz commented 6 months ago

@Kaspazza I've fixed the problem in dev branch. Could you try dev branch?

Kaspazza commented 5 months ago

@liquidz It works great! Thanks!

liquidz commented 5 months ago

@Kaspazza Thanks for your confirmation! I'll release new version in this weekend.

liquidz commented 5 months ago

@Kaspazza Just released v2.8.1194 :)