search

liquidz / iced-nrepl

nREPL middleware to support vim-iced.
Eclipse Public License 1.0
13 stars 2 forks source link

Collaboration with CIDER's team #2

Open bbatsov opened 5 years ago

bbatsov commented 5 years ago

Hey there!

vim-iced looks like an awesome project! Congratulations for creating it!

I'm the author of CIDER and I noticed that you've created some extra middleware for vim-iced, so I just wanted to let you know that our team really wants to have orchard, cider-nrepl and refactor-nrepl be useful to as many editors as possible, so if you feel some of the functionality you've developed is generic enough we'd be glad to have it there.

I'm not sure about the rationale behind the different ops you've added so far, but some seem like something that we can definitely use in CIDER as well (e.g. the grimoire stuff, the linter stuff, etc).

Btw, I was under the impression there's already some op in cider-nrepl to return a list of the project namespaces. There are also ops about formatting the code with cljfmt, so I'd be curious to hear why you couldn't reuse those.

Anyway, just wanted to let you know I'm excited to see another person working on nREPL middleware and that me and the rest of the CIDER/nREPL team are here to help and support you. It'd be great if there was more collaboration between the various tool authors. :-)

liquidz commented 5 years ago

@bbatsov vim-iced is still alpha version, and iced-nrepl is a experimental project to try function I want to use with vim-iced.

so if you feel some of the functionality you've developed is generic enough we'd be glad to have it there.

I'm happy to hear that! I would like to contribute some codes what I think useful to cider/refactor-nrepl.

Btw, I was under the impression there's already some op in cider-nrepl to return a list of the project namespaces. There are also ops about formatting the code with cljfmt, so I'd be curious to hear why you couldn't reuse those.

I couldn't find the op that returns orchard.namespace/project-namespaces simply. ns-list seems to return all loaded namespaces.

format-code op is not accepting options for cljfmt.core/reformat-string. https://github.com/weavejester/cljfmt/blob/0338e08daf8b6ede3cd1a97a09ba5d660ef0f6ef/cljfmt/src/cljfmt/core.cljc#L384 Especially, I would like to specify :indents for indent customization.

bbatsov commented 5 years ago

I couldn't find the op that returns orchard.namespace/project-namespaces simply. ns-list seems to return all loaded namespaces.

Hmm, I guess that's some oversight on our end then. We should add this to cider-nrepl.

Especially, I would like to specify :indents for indent customization.

That's a good addition. Feel free to submit this upstream.