search

liquidz / vim-iced

Clojure Interactive Development Environment for Vim8/Neovim
https://liquidz.github.io/vim-iced/
MIT License
518 stars 35 forks source link

Change color of temporary evaluation result? #389

Closed mars0i closed 2 years ago

mars0i commented 2 years ago

When evaluating code with <Leader>ei, <Leader>et, etc., the result is temporarily displayed to the right of the line after "=> ". The displayed result is in the the Comment color from the user's color scheme.

Is there a way to change this color to make it different from the Comment color? Since comments are static parts of a source file, and the evaluation result is temporary, for me it would be nicer if the color of the evaluation result conveyed that it was temporary and made it stand out. (I know I can change the color of the temporary result display by changing my Comment color, but I want the result display to be in a different color from my comments.)

Or if there's no way to change it, maybe I could just modify my own copy of the .vim viles to make the color different? I haven't yet figured out which file this is in. Thanks.

liquidz commented 2 years ago

@mars0i Thanks for your reporting! Currently, the highlight setting for popuped results are fixed.

You can change it at below: https://github.com/liquidz/vim-iced/blob/a28cd81990d46816b599f10cafe69ea7e4898f9f/autoload/iced/nrepl/eval.vim#L57

But it may be good to add option for modifing the highlight setting.

mars0i commented 2 years ago

Thanks @liquidz! I've changed it now.

I like the idea of adding an option for changing the highlight setting for the evaluation results. I suppose that some people might want to be able to configure other colors, such as the stdout popup. (I don't need to change the stdout popup colors.)

liquidz commented 2 years ago

@mars0i I added g:iced#eval#popup_highlight option to change the highlight setting to dev branch. https://vim-iced-nightly.netlify.app/vim-iced.html#g%3Aiced%23eval%23popup_highlight

Could you try dev branch?

mars0i commented 2 years ago

Yes, works perfectly for me. Thank you!

liquidz commented 2 years ago

@mars0i Just released v3.8.3 #392

mars0i commented 2 years ago

Excellent--thanks. I just updated.