search

liquidz / vim-iced

Clojure Interactive Development Environment for Vim8/Neovim
https://liquidz.github.io/vim-iced/
MIT License
518 stars 35 forks source link

Avoid add M exec-opt twice #412

Closed bootleq closed 2 years ago

bootleq commented 2 years ago

Hi, when using iced repl command, sometimes I need to use different aliases with clj -M exec option, for example iced repl -M:xx:yy:iced, but it produces another -M in MAIN_FLAG handling and makes the prior no-effect.

This PR try to detect -M in command line options and avoid second -M as an fix.

bootleq commented 2 years ago

Hi, thanks for the reminder, I have changed the template, too.

Feel uncertain to add note to template, because someone didn't notice the file like me, will also overlook the note.

liquidz commented 2 years ago

@bootleq Thank you!

Feel uncertain to add note to template, because someone didn't notice the file like me, will also overlook the note.

If we add notes to the template and run make bin, bin/iced will also have same notes.

So it should help to avoid overlooking.

bootleq commented 2 years ago

If we add notes to the template and run make bin, bin/iced will also have same notes.

So it should help to avoid overlooking.

Understand, how about this comment?

# This file is generated by `make bin`.
liquidz commented 2 years ago

It might be helpful to specify what action to take if someone want to make a change. e.g.

# === WARNING ===
# bin/iced is generated by `make bin`.
# Please edit clj/template/iced.bash instead of bin/iced.
bootleq commented 2 years ago

Thanks, I have added the comment, hope further contributors will find those files were changed together.