search

liquidz / vim-iced

Clojure Interactive Development Environment for Vim8/Neovim
https://liquidz.github.io/vim-iced/
MIT License
516 stars 35 forks source link

:IcedCleanNs removes `:clj-kondo/ignore` reader comments #465

Open noahmoss opened 11 months ago

noahmoss commented 11 months ago

Hey @liquidz!

If a namespace has #_{:clj-kondo/ignore [:deprecated-namespace]} above a required namespace, it is removed after running :IcedCleanNs. Would it be possible for the command to retain these comments?

liquidz commented 11 months ago

@noahmoss Thanks for your report!

:IcedCleanNs uses the refactor-nrepl's feature, so I'll have a look at the process in refactor-nrepl :)

liquidz commented 11 months ago

@noahmoss Sorry for late reply 🙇 Hmm, currently there is no way to retain those comments in refactor-nrepl.

And also tool-specific rules like #_:clj-kondo/ignore seems not to be welcomed. https://github.com/clojure-emacs/refactor-nrepl/issues/359#issuecomment-1019516325

I have no plan to implement own implementation of retaining those comments, since it can also be excluded in .clj-kondo/config.edn.