liquity / ChickenBond

GNU General Public License v3.0
32 stars 5 forks source link

feat: Add Egg NFT trait weights and affinity #206

Closed bingen closed 1 year ago

bingen commented 1 year ago

Fixes #203

danielattilasimon commented 1 year ago

Failure occurs due to mismatch between the returns types of IChickenBondManager.getBondData() and DummyChickenBondManager.getBondData(): https://github.com/liquity/ChickenBond/runs/8287255748?check_suite_focus=true

That should be fixed if we decide not to go ahead with adding the claimed bLUSD amount to bond data, or if we do, then we should fix DummyChickenBondManager.

bingen commented 1 year ago

Failure occurs due to mismatch between the returns types of IChickenBondManager.getBondData() and DummyChickenBondManager.getBondData(): https://github.com/liquity/ChickenBond/runs/8287255748?check_suite_focus=true

That should be fixed if we decide not to go ahead with adding the claimed bLUSD amount to bond data, or if we do, then we should fix DummyChickenBondManager.

Thanks, fixed!