search

liqula / react-hs

A GHCJS binding to React based on the Flux design. The flux design pushes state and complicated logic out of the view, allowing the rendering functions and event handlers to be pure Haskell functions.
32 stars 10 forks source link

Why are there so many default extensions. #56

Closed tysonzero closed 7 years ago

tysonzero commented 7 years ago

There is no way they are all being used, or are they?

fisx commented 7 years ago

I think they are. Even if not, I do not see a problem with extending the language to some reasonable default extension set.

Please re-open if you know if any practical problems that arise from any of the enabled extensions.

fisx commented 7 years ago

while i stand by my claim that most of them are ok, i found a few that shouldn't be there. i tweaked things a little bit in #57. sorry for rejecting this prematurely! please re-open if you're still unhappy about anything in particular. (i like the fact that we have the same set of language extensions everywhere so we only need to copy&paste the whole block without adding them as needed all the time.)

tysonzero commented 7 years ago

Well I know for example my linter (hlint) is going to whine at me about unused language extensions, and my personal preference is to only put the necessary language extensions in each file. To me it is similar to having a bunch of unused imports.