search

liqula / react-hs

A GHCJS binding to React based on the Flux design. The flux design pushes state and complicated logic out of the view, allowing the rendering functions and event handlers to be pure Haskell functions.
32 stars 10 forks source link

52 #63

Open danse opened 7 years ago

danse commented 7 years ago

Fixes #52

fisx commented 7 years ago

could you take care of the warning on travis? if not i'll do it eventually. thanks!

danse commented 7 years ago

What is the desired way to fix this? Seems like you are defining a common interface for building within this project, so if you want i could ditch the Makefile, move everything to a build.sh script and update the related docs

danse commented 7 years ago

ideally we'd like to offer users an homogeneous build methodology like in the else branch up there, but the todo case has some custom tweaks so it's more suited to be encapsulated into a build.sh up to the moment when we can remove the workarounds

danse commented 7 years ago

now this works when running ./build.hs in the todo folder, but it fails when running all the tests with docker from the root folder. it says that Javascript dependencies might be missing, which is weird because when i try ./build.hs in the todo folder everything builds just fine. if you don't have time i'll try again later

--  While building package react-hs-examples-0.1.0 using:
      /root/.stack/setup-exe-cache/x86_64-linux/Cabal-simple_mPHDZzAJ_1.24.2.0_ghcjs-0.2.1.9008011_ghc-8.0.2 --builddir=.stack-work/dist/x86_64-linux/Cabal-1.24.2.0_ghcjs build exe:todo exe:todo-node --ghcjs-options " -ddump-hi -ddump-to-file"
    Process exited with code: ExitFailure 1
    Logs have been written to: /react-hs/react-hs-examples/todo/.stack-work/logs/react-hs-examples-0.1.0.log

    Configuring react-hs-examples-0.1.0...
    Warning: Unknown extensions: TypeFamilyDependencies
    Preprocessing executable 'todo' for react-hs-examples-0.1.0...
    [1 of 5] Compiling TodoStore        ( src/TodoStore.hs, .stack-work/dist/x86_64-linux/Cabal-1.24.2.0_ghcjs/build/todo/todo-tmp/TodoStore.js_o ) [flags changed]

    /react-hs/react-hs-examples/todo/src/TodoStore.hs:26:1: error:
        Failed to load interface for ‘React.Flux’
        Perhaps you haven't installed the "js" libraries for package ‘react-hs-0.1.0’?
        Use -v to see a list of the files searched for.
tysonzero commented 6 years ago

What's the status on this?

danse commented 6 years ago

no updates since my last comment. now i have less availability to work on this library so i would probably be very slow or make no progress at all on this in the upcoming future