Keymap should not throw error when unbinding a thing that is no longer bound

liqvidjs / liqvid

Library for interactive videos in React

https://liqvidjs.org

MIT License

761 stars 39 forks source link

Closed ysulyma closed 1 year ago

ysulyma commented 2 years ago

since other code could delete the bindings to override keyboard controls.

anishg-cn commented 1 year ago

@ysulyma is this bug related to the following error? If yes, then can you please tell the status of it?

ysulyma commented 1 year ago

@anishg-cn upgrade to latest version, this was fixed in liqvid@2.1.9 / @liqvid/keymap@1.1.4

anishg-cn commented 1 year ago

@ysulyma ok thanks