Feat/accept third party cookies

TimLehner commented 2 years ago

Description

Similar behaviour is available using preLoginSelector, however this only works for accepting cookies on the user's application. This change:

allows configuring multiple additional selectors, which will be used after the initial login click, but before attempting to enter third-party credentials
allows a user to configure the plugin to click third-party GDPR-related warnings, for example those seen on Facebook

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Trying to test a more-complicated login flow, where clicking the login button with existing React state may send additional context on the backend, e.g. for linking existing accounts. As a result I don't think I'm able to navigate directly to /api/auth/signin/facebook, instead I want to go to /api/auth/signin and use a selector to find the 'Facebook' button.

How Has This Been Tested?

Tested as part of integrating in my own project.

For example, took accept only essential cookies on Facebook:

const socialLoginOptions = {
  username,
  password,
  ...,
  loginSelector: 'form[action="http://localhost:3000/api/auth/signin/facebook"] > button[type="submit"]',
  trackingConsentSelectors: [
    'button[data-testid="cookie-policy-dialog-manage-button"]',
    'button[data-testid="cookie-policy-manage-dialog-accept-button"]'
  ]
}
cy.task('FacebookSocialLogin', socialLoginOptions).then(({ cookies, lsd, ssd }) => {
  ...
}

Screenshots (if appropriate):

Checklist:

[x] I have updated the documentation (if required).
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I added a picture of a cute animal cause it's fun

lirantal commented 2 years ago

That looks good @TimLehner Thank you 👏

TimLehner commented 2 years ago

That's great, thanks! Is there anything I need to do to get this into a minor release?

lirantal commented 2 years ago

:tada: This PR is included in version 1.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

lirantal commented 2 years ago

:-)

Thank you again @TimLehner

lirantal / cypress-social-logins