search

lirantal / daloradius

daloRADIUS is an advanced RADIUS web management application for managing hotspots and general-purpose ISP deployments. It features user management, graphical reporting, accounting, a billing engine, and integrates with OpenStreetMap for geolocation. The system is based on FreeRADIUS with which it shares access to the backend database.
http://www.daloradius.com
GNU General Public License v2.0
649 stars 332 forks source link

Install script does not check for write access to /proc #542

Open Somebodyisnobody opened 1 month ago

Somebodyisnobody commented 1 month ago

Describe the bug Install script will fail on systemctl restart freeradius.service in the function freeradius_enable_restart() if wirte access to /proc is denied.

To Reproduce

Expected behavior The script should check wirte access before to make it more resilient. Just executing the script again after giving write access to /proc will fail because the directory /var/www/daloradius already exists and the first execution of the script leavs the installation in an unfinished state.

Screenshots /

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

I am using a Proxmox Virtual Environment server (PVE) with this script running in a container where the nested feature was turned off which denied access to /proc and /sys.

filippolauria commented 1 month ago

@Somebodyisnobody at the moment, the installation script is not supported on Debian LXC containers that do not have the nesting feature enable on a Proxmox virtualization environment.

Somebodyisnobody commented 1 month ago

That's no problem. My intention was only to give you feedback to have the chance improving the installation script. I fixed it for me and hopefully my problem description and solution will help others that have the same issue until you had time to enhance the script if you want.

filippolauria commented 1 month ago

Thank you for your feedback. If you want to push your fixes to this repository, it is actually quite simple. Have a look at the first contributions how to :smile: