search

lirantal / detect-secrets

A developer-friendly secrets detection tool for CI and pre-commit hooks based on Yelp's detect-secrets
Apache License 2.0
49 stars 4 forks source link

version of detect-secrets on the build of dockerhub is outdated #17

Closed belaaiza closed 3 years ago

belaaiza commented 3 years ago

Expected Behavior

The lib should install the latest version of detect-secrets on docker.

Current Behavior

If I run the image installed by the lib with /bin/bash as entrypoint and run detect-secrets --version, it shows the version 1.0.3, which is not the latest version of detect-secrets.

Captura de Tela 2021-05-05 às 16 25 05

Possible Solution

I think that the image should be rebuild and updated on dockerhub.

Steps to Reproduce (for bugs)

  1. npm instal --save-dev detect-secrets
  2. npx detect-secrets (git ls-files)
  3. docker run --entrypoint /bin/bash -it lirantal/detect-secrets
  4. detect-secrets --version

Context

The latest version ignores the package-lock.json file, it would be nice to have this feature.

Your Environment

belaaiza commented 3 years ago

@lirantal can you update the image on docker hub?

lirantal commented 3 years ago

@belaaiza looking into it now

lirantal commented 3 years ago

@belaaiza new image pushed with latest 1.1.0 from yelp: image

Thank you for the reminder to update :-)