lirantal / detect-secrets

A developer-friendly secrets detection tool for CI and pre-commit hooks based on Yelp's detect-secrets

Apache License 2.0

49 stars 4 forks source link

fix: avoid fixed name for instantiating the container #4

Closed lirantal closed 5 years ago

lirantal commented 5 years ago

Description

Avoid hard-coding the container name for detect-secrets

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Fixes #3

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

[ ] I have updated the documentation (if required).
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I added a picture of a cute animal cause it's fun

codecov-io commented 5 years ago

Codecov Report

Merging #4 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #4   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
  Branches        3      3           
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98e22a2...0d9d696. Read the comment docs.

lirantal commented 5 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: