search

lirantal / docker-detect-secrets

A docker image for Yelp's docker-secrets python application
Apache License 2.0
5 stars 4 forks source link

Update detect-secrets #2

Closed juanpicado closed 3 years ago

juanpicado commented 3 years ago

I am having issues with ignoring yarn v2 lock files and I want to use --exclude-files feature.

   ✔ eslint .
      ✖ detect-secrets-launcher --baseline .secrets-baseline --exclude-files *.lock
        git add

✖ detect-secrets-launcher --baseline .secrets-baseline --exclude-files *.lock found some errors. Please fix them and try committing again.

usage: detect-secrets-hook [-h] [-v] [--version] [--baseline BASELINE]
                         [--exclude-lines EXCLUDE_LINES]
                         [--word-list WORD_LIST_FILE] [--use-all-plugins]
                         [-n] [--base64-limit [BASE64_LIMIT]]
                         [--hex-limit [HEX_LIMIT]] [--no-private-key-scan]
                         [--no-softlayer-scan] [--no-aws-key-scan]
                         [--no-basic-auth-scan] [--no-slack-scan]
                         [--no-keyword-scan] [--no-artifactory-scan]
                         [--no-stripe-scan] [--no-jwt-scan]
                         [--no-mailchimp-scan] [--no-base64-string-scan]
                         [--no-hex-string-scan]
                         [--keyword-exclude KEYWORD_EXCLUDE]
                         [filenames [filenames ...]]
detect-secrets-hook: error: unrecognized arguments: --exclude-files
husky > pre-commit hook failed (add --no-verify to bypass)

https://github.com/Yelp/detect-secrets/blob/master/CHANGELOG.md#tada-new-features

Can we update to v1? I'm not sure whether I can actually do something from my side.

lirantal commented 3 years ago

@juanpicado yes! new version pushed in latest docker image: https://hub.docker.com/r/lirantal/detect-secrets have fun and hopefully there aren't any regressions :-)