lirantal / dockly

Immersive terminal interface for managing docker containers and services
https://lirantal.github.io/dockly/
MIT License
3.79k stars 151 forks source link

fix: increase limit on event listeners warning #255

Closed lirantal closed 1 year ago

lirantal commented 1 year ago

Summary

Fixes #249

Proposed Changes

The toolbar widget (toolbar.on()) registers 11 event listeneres which triggers a Node.js memory leak warning:

erik@WS-91019:~$ dockly
(node:15356) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 key listeners added to [myWidget]. Use emitter.setMaxListeners() to increase limit
(Use node --trace-warnings ... to show where the warning was created)

There is no actual memory leak however, as it registers exactly 11 key presses for the toolbar. This PR increases the limit to prevent the internal Node.js warning.

Checklist

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.23.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: