lirantal / essential-nodejs-security-book

Documentation for Essential Node.js Security
https://leanpub.com/nodejssecurity
94 stars 34 forks source link

Missing topics, thoughts, and discussion #2

Closed SOSANA closed 7 years ago

SOSANA commented 7 years ago

@lirantal hope all is well my brotha from anotha motha :)

Few topics felt I needed to address that were missing.


RE: usage with bcrypt

my suggest is to mention that it exists and this is an alternative work around to avoid messing around with compilers, additional c++ packages, and pointing your os env variable to python >=2.5 and <3.0 version as most are preinstalled with python >3.0


RE: usage with passport-local strategy

my suggestion is to elaborate more on why you would want to consider using this and why its one of the most used local auth stradegy. In a world where everything seems to be going microservices (ex: api servers and seperatation of the front-end) vs monolith architecture.


Re: JWT

my suggestion is to elaborate more on this subject and provide example


RE: CORS

my suggestion is to elaborate more on this subject and provide example


So far enjoy the straight forwardness of the book with clear explanations, and straight to the point recommendations for each topic.

Currently reviewing and re-reviewing... reviewing

lirantal commented 7 years ago

Hey Zach,

Really great summary and notes! Thanks! :-) I'm going to open each item as a different issue so we can address them individually and it would be easy to follow-up on.

Awesome job reviewing it! Can't wait for more issues from you to open or PR for suggesting fixes.