search

lirantal / essential-nodejs-security-book

Documentation for Essential Node.js Security
https://leanpub.com/nodejssecurity
94 stars 34 forks source link

Review: salt & hashing - using bcrypt-nodejs vs bcrypt #3

Closed lirantal closed 7 years ago

lirantal commented 7 years ago

Reference: original review notes by @sosana: https://github.com/lirantal/nodejssecurity/issues/2

salt & hashing - using bcrypt-nodejs vs bcrypt

It has issues with windows and linux os. Mind you it depends on the linux distributions (redhat/ubuntu/debian). Some of the problems for both are os env variables utilizing node-gyp python >=2.5 and <3.0 version

my suggest is to mention that it exists and this is an alternative work around to avoid messing around with compilers, additional c++ packages, and pointing your os env variable to python >=2.5 and <3.0 version as most are preinstalled with python >3.0

lirantal commented 7 years ago

bcrypt-nodejs is un-maintained or at least hasn't seen any changes in the past 2 years so I am not very eager to document it in the book.

However I totally agree with your notes and taken care of updating the text and address this issue for Windows or Mac users.

@sosana please review the PR https://github.com/lirantal/nodejssecurity/pull/4/