lirantal / is-website-vulnerable

finds publicly known security vulnerabilities in a website's frontend JavaScript libraries

Apache License 2.0

1.94k stars 111 forks source link

Gracefully handle missing URL argument #58

Closed itaisteinherz closed 4 years ago

itaisteinherz commented 4 years ago

(image source: https://aquarium.org/sea-otter-holding-facility/)

Description

This PR makes the CLI gracefully handle cases where a URL isn't provided to the CLI by the user, by asking for it while running (using inquirer, since I've used it in the past and know it works well). This fixes #56.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

56

How Has This Been Tested?

I locally tested the CLI to make sure this works.

Screenshots (if appropriate):

Checklist:

[x] I have updated the documentation (if required).
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I added a picture of a cute animal cause it's fun

itaisteinherz commented 4 years ago

(Last note: I couldn't get the commit hooks to work on my machine, and so the commit messages might be a bit off. Feel free to update the PR title, and I can also update my commit messages in case that's necessary.)