lirantal / is-website-vulnerable

finds publicly known security vulnerabilities in a website's frontend JavaScript libraries
Apache License 2.0
1.94k stars 111 forks source link

Add descriptive message for protocol timeout #75

Closed rajkumaar23 closed 4 years ago

rajkumaar23 commented 4 years ago

Description

This PR tries to handle the error with a code of PROTOCOL_TIMEOUT with a descriptive error message.

Types of changes

Related Issue

Fixes #73

Motivation and Context

When there's a PROTOCOL_TIMEOUT error, we need to detect and gracefully handle with a descriptive error message.

How Has This Been Tested?

Used the command to run against a website that is blocked by my ISP and received this descriptive error message.

Screenshots (if appropriate):

Checklist:

rajkumaar23 commented 4 years ago

@lirantal Let me know if you could think of a better descriptive message for the timeout.

lirantal commented 4 years ago

Looks good to me, thanks Raj! ❤️

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.14.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: