ReferenceError: echoMode is not defined

[pqplayground]

1.When liri-browser running in my QtCreator(Based on Qt 5.5.1 (MSVC 2013, 32 bit)), it output:

file:///C:/Qt/Qt5.5.1/5.5/msvc2013/qml/QtQuick/Controls/Styles/Material/TextFieldStyle.qml:35: ReferenceError: echoMode is not define

2.When I Select MaterialWindow, I can't find it on the taskbar, should use

flags: root.app.customFrame ? (Qt.FramelessWindowHint | Qt.window) : Qt.Window

instead of

flags: root.app.customFrame ? Qt.FramelessWindowHint : Qt.Window ?

3.the property icon in _QuickSearchesView.qml_ and _SettingsView.qml_ should be

icon: "icons://action/settings

4._TabBarItemDelegate.qml_ , use

source: modelData.view.icon

to

name: modelData.view.icon

[timsueberkrueb]

@zhengw1985 For 1. I think you can safely ignore this. Thanks for the hint with 2. We'll look into it. regarding 3 and 4: what's the problem with that? Can you explain more precisely what you mean?

[pqplayground]

@tim-sueberkrueb ,Thank you for your response.When I console.debug() the Icon's name , it shows

qml: Icon.qml https://www.google.de/images/branding/product/ico/googleg_lodp.ico file:///C:/Qt/Qt5.5.1/5.5/msvc2013/qml/Material/Icon.qml:63:5: QML Image: Cannot open: file:///C:/Qt/Qt5.5.1/5.5/msvc2013/qml/Material/icons/https:/.svg

see details about Icon.qml in Material.

property string name property string source: "icon://" + name

when you use name: modelData.view.icon, the source will parse for icon://https://.../ico/google_lodp.ico this is a error.

[timsueberkrueb]

@zhengw1985 There are two "icons". One of them is an Image which handles favicons. The other one, an actual Material.Ìcon just handles special items (e.g. settings). https://github.com/liri-project/liri-browser/blob/master/src/qml/TabBarItemDelegate.qml#L127 Of course this icon doesn't work if it's a favicon. In this case it's just not visible as the Image shows the icon.

[pierremtb]

@zhengw1985 Regarding the Windows issue, I had to move to VS2015, and sadly msvc2015 isn't currently supported by Qt (but 5.6 is coming, and it will support it), so I couldn't test on Windows for a while. Could you submit a pull request to fix this ?