search

liri-project / liri-browser

📕 Archive - Development has moved to https://github.com/lirios/browser.
GNU General Public License v3.0
301 stars 42 forks source link

Fixed add to dash #223

Closed kuglisb closed 8 years ago

kuglisb commented 8 years ago

icons.better-idea.org API must have changed and currently the returned answer containes the required json result, but not that only. I've fixed the API function according to the documentation. Also fixed the missing error handling which actually prevented this to work. The bug was introduced in #179.

timsueberkrueb commented 8 years ago

Thanks for you contribution. Though the icon url is always FALSE for me when I try adding a website to the dash. I tried GitHub, Google and Twitter. Does this work for you properly?

kuglisb commented 8 years ago

Sorry, I've forgot to apply the changes to my forked repo. It works for me now.

timsueberkrueb commented 8 years ago

Awesome, thank you!