liri-project / liri-browser

📕 Archive - Development has moved to https://github.com/lirios/browser.
GNU General Public License v3.0
301 stars 42 forks source link

Shadow below addressbar is too thick #75

Closed PalmerAL closed 8 years ago

PalmerAL commented 9 years ago

The shadow distracts from the webpage a lot, and isn't material-like either - compare the shadow to http://www.google.com/design/spec/material-design/introduction.html#introduction-principles.

Might be a qml-material issue.

timsueberkrueb commented 9 years ago

@PalmerAL https://www.google.com/design/spec/what-is-material/elevation-shadows.html#elevation-shadows-elevation-android- App bar: 4dp elevation?

pierremtb commented 9 years ago

@PalmerAL Regarding Material specs, we're good. However, I agree with @PalmerAL, this shadow should be smaller.

timsueberkrueb commented 9 years ago

@pierremtb @PalmerAL I'm personally happy with the shadow. This is actually funny because in the past it was thinner and someone complained it was not thick enough. What elevation would you suggest?

pierremtb commented 9 years ago

Well there is no shadow anymore (I don't know why). I close this for now

timsueberkrueb commented 9 years ago

I believe you disabled the shadow because it looks odd in combination with the CSD. Please keep things like this open if there is no solution otherwise we'd forget them.

pierremtb commented 9 years ago

@tim-sueberkrueb Yeah you're right (for both). By the way I think that it looks better without any toolbar shadow, because when the color option is enabled, there is very nice continuity (I don't know if it's the right word sorry) between the website header and the toolbar on some websites. But it's just my opinion. I think an option would be great (maybe a slider, from 0dp to 4dp). I will look into it (especially with CSD).

I was talking of something like that :  capture du 2015-10-06 17 58 47

timsueberkrueb commented 9 years ago

@pierremtb yeah, an option would be the best thing.

IdrissDimson commented 9 years ago

any update on this. i'm feeling leave it the way it is now.

timsueberkrueb commented 8 years ago

Currently there is no shadow at all, but I personally think there should be one do make the difference between page and toolbar clearer.

IdrissDimson commented 8 years ago

i like it the way it is

pierremtb commented 8 years ago

I've been playing around with this shadow. Here are some screenshots with different metrics on the same website : the new MD version of G+

IMO, this toolbar shadow is a bit "too much" on a MD website, that uses a MD toolbar too. Another thing : there is no way to use the ink animation with a elevated toolbar, because it needs to be transparent to let the ink go under, which isn't possible with a shadow (because shadows in Qt are rectangles that go under the targeted component). Maybe we could make it optional : either you choose an elevated toolbar without the ink animation, or you choose a flat toolbar, with the ink animation.

IdrissDimson commented 8 years ago

Yeah I agree, the shadow will be too busy on a MD website.

pierremtb commented 8 years ago

Well, let's follow our guidelines : when we don't know, we add an option :) capture d ecran de 2015-12-30 18-15-16

I can finally close this issue!