search

liri-project / liri-music

:closed_book: Archive - Development has moved to https://github.com/lirios/music
GNU Lesser General Public License v2.1
33 stars 1 forks source link

Primary dark color doesn't correspond to primary color #2

Closed iBelieve closed 8 years ago

iBelieve commented 8 years ago

On Papyros, the primary dark color is used for the window decorations, so it's important that the primary color corresponds with the primary color:

green island_003

I was going to submit a pull request for this, but I noticed that the primary color is being pulled from the user settings. I would suggest not doing this, and pick primary and accent colors to reflect your app's branding. The only time you should have a user-customizable style in my opinion is for a reading app with day/night mode.

nickgermaine commented 8 years ago

Ok thanks. I'll use a specified theme color for this, and match the dark color to it.

iBelieve commented 8 years ago

There's also a little trick you can do with the theme:

theme: {
    primaryColor: "deepOrange"
}

Note how it's setting it to a named color instead of a hex like primaryColor: Palette.colors["deepOrange]["500"] does. When you do this, it'll pull the primaryColor from the Palette and automatically set primaryDarkColor to the corresponding dark color.

nickgermaine commented 8 years ago

Awesome! That's a handy trick.

nickgermaine commented 8 years ago

I've got this fixed in local source, will be pushed soon.