search

liriliri / eruda

Console for mobile browsers
https://eruda.liriliri.io
MIT License
18.62k stars 1.2k forks source link

Toggle switches in Settings are very difficult to use #9

Closed hanthomas closed 8 years ago

hanthomas commented 8 years ago

I noticed that the toggle switches in the Settings tab don't respond very well to either taps (or clicks in desktop browser). I have tap on them several times in order to get it to change state. All other UI interactions work just fine... just these toggle switches are not very responsive. My app has code to optimize touch/click events, so I suspect this might be interfering with these toggles. Any chance the toggles could just be changed to ordinary checkboxes?

surunzi commented 8 years ago

Are you using libraries like fastclick or you write something similar yourself? The switch buttons are just some ordinary checkboxes with styles, no click or tap events attached. This is weird. I'll see if there's a good way to solve conflicts with libraries such as fastclick later.

surunzi commented 8 years ago

Found a solution here: https://github.com/ftlabs/fastclick/issues/90 I tried it with fastclick, and it works just fine. @hanthomas Download v0.5.9, and see if it's still hard to toggle the switches.

hanthomas commented 8 years ago

@surunzi Thanks for your quick response. This is working perfectly now.