a332ebd20e20d2cfc9619bd0fdf5c3a10da00b19 prevents lirios-shell from building

[n3rdopolis]

a332ebd20e20d2cfc9619bd0fdf5c3a10da00b19 seems to be the most relevant commit, building shell I get this error

-- Found Wayland_Server: /opt/lib/x86_64-linux-gnu/libwayland-server.so (found version "1.21.90") 
-- Found Wayland: /opt/lib/x86_64-linux-gnu/libwayland-server.so (found suitable version "1.21.90", minimum required is "1.15") found components: Server 
CMake Error at /opt/share/cmake-3.22/Modules/CMakeFindDependencyMacro.cmake:47 (find_package):
  By not providing "FindXkbCommon.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "XkbCommon", but CMake did not find one.

  Could not find a package configuration file provided by "XkbCommon" with
  any of the following names:

    XkbCommonConfig.cmake
    xkbcommon-config.cmake

  Add the installation prefix of "XkbCommon" to CMAKE_PREFIX_PATH or set
  "XkbCommon_DIR" to a directory containing one of the above files.  If
  "XkbCommon" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  /opt/lib/x86_64-linux-gnu/cmake/Liri1AuroraXkbCommonSupport/Liri1AuroraXkbCommonSupportDependencies.cmake:9 (find_dependency)
  /opt/lib/x86_64-linux-gnu/cmake/Liri1AuroraXkbCommonSupport/Liri1AuroraXkbCommonSupportConfig.cmake:32 (include)
  /opt/share/cmake-3.22/Modules/CMakeFindDependencyMacro.cmake:47 (find_package)
  /opt/lib/x86_64-linux-gnu/cmake/Liri1AuroraCompositor/Liri1AuroraCompositorDependencies.cmake:10 (find_dependency)
  /opt/lib/x86_64-linux-gnu/cmake/Liri1AuroraCompositor/Liri1AuroraCompositorConfig.cmake:32 (include)
  src/compositor/CMakeLists.txt:21 (find_package)

-- Configuring incomplete, errors occurred!
See also "/srcbuild/lirios-shell/build/CMakeFiles/CMakeOutput.log".

Not sure if I am missing anything else...

[plfiorini]

This particular issue was fixed, but for some reason CI fails: https://github.com/lirios/aurora-compositor/actions/runs/3586802132/jobs/6036432705 There might be something related to xkbcommon still going on. I'm investigating, although it builds just fine with QtCreator with the "superbuild".

[plfiorini]

Fixed!

[n3rdopolis]

Thanks, but I am getting

[ 26%] Building CXX object src/compositor/CMakeFiles/AuroraCompositor.dir/compositor_api/aurorawaylandoutputmode.cpp.o
[ 26%] Building CXX object src/compositor/CMakeFiles/AuroraCompositor.dir/compositor_api/aurorawaylandresource.cpp.o
In file included from /srcbuild/aurora-compositor/build/include/LiriAuroraCompositor/0.0.0/LiriAuroraCompositor/private/aurorawaylandcompositor_p.h:1,
                 from /srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandclient.cpp:33:
/srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandcompositor_p.h:54:10: fatal error: LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h: No such file or directory
   54 | #include <LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/compositor/CMakeFiles/AuroraCompositor.dir/build.make:624: src/compositor/CMakeFiles/AuroraCompositor.dir/compositor_api/aurorawaylandclient.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandcompositor.cpp:32:
/srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandcompositor_p.h:54:10: fatal error: LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h: No such file or directory
   54 | #include <LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/compositor/CMakeFiles/AuroraCompositor.dir/build.make:638: src/compositor/CMakeFiles/AuroraCompositor.dir/compositor_api/aurorawaylandcompositor.cpp.o] Error 1
In file included from /srcbuild/aurora-compositor/build/include/LiriAuroraCompositor/0.0.0/LiriAuroraCompositor/private/aurorawaylandcompositor_p.h:1,
                 from /srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandkeyboard_p.h:44,
                 from /srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandkeyboard.cpp:32:
/srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandcompositor_p.h:54:10: fatal error: LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h: No such file or directory
   54 | #include <LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/compositor/CMakeFiles/AuroraCompositor.dir/build.make:680: src/compositor/CMakeFiles/AuroraCompositor.dir/compositor_api/aurorawaylandkeyboard.cpp.o] Error 1
In file included from /srcbuild/aurora-compositor/build/include/LiriAuroraCompositor/0.0.0/LiriAuroraCompositor/private/aurorawaylandcompositor_p.h:1,
                 from /srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandoutput.cpp:38:
/srcbuild/aurora-compositor/src/compositor/compositor_api/aurorawaylandcompositor_p.h:54:10: fatal error: LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h: No such file or directory
   54 | #include <LiriAuroraXkbCommonSupport/private/auroraxkbcommon_p.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [src/compositor/CMakeFiles/AuroraCompositor.dir/build.make:708: src/compositor/CMakeFiles/AuroraCompositor.dir/compositor_api/aurorawaylandoutput.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1235: src/compositor/CMakeFiles/AuroraCompositor.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

now

It is Cmake v3.22.0 if that helps, I could try a different version if needed

[n3rdopolis]

Doing a full rebuild of everything (cmake, qt, kde and all of Liri), and now I can't replicate the missing header again